This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Check the installer version #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#221 has the advantage of skipping this warning for the self-update command itself |
|
No problem for keeping #221 ;) |
|
I'm closing this in favor of #221. The other one was submitted earlier and the code looks a bit simpler. Anyway, thanks @Pierstoval for your help with this. As always, your work is really appreciated! |
|
"Earlier" is just about some few minutes 😆 But yeah I should have waited before submitting a PR for nothing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation that will compare the local version with the distant one.
Actually, this does the check on every command, but I'd like to discuss about how we could improve this, because I don't know what kind of implications there is in requesting the version on each command...