Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

silence wrong exception #166

Merged
merged 1 commit into from
Jun 10, 2015
Merged

silence wrong exception #166

merged 1 commit into from
Jun 10, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 9, 2015

This fixes #163 by silencing the mistakenly thrown exception.

@weaverryan
Copy link
Member

we should open an issue or a PR on the SE to remind fabpot to update the SE to the latest edition of the distribution bundle to fix this. I'd hate to have 2.7.1 released without it.

I'm +1 for this - we might as well fix it here to solve issues. We can remove it later when it's only affecting old versions. For a tool that's meant to help people, I think not merging this would be a little counter productive. So, yes for me :)

@javiereguiluz
Copy link
Member

This is really nice @xabbuh. Thanks a lot for working on this. And I agree with @weaverryan, we should fix this problem upstream in Symfony as soon as possible.

@javiereguiluz javiereguiluz merged commit e70acbd into symfony:master Jun 10, 2015
javiereguiluz added a commit that referenced this pull request Jun 10, 2015
This PR was merged into the 1.0-dev branch.

Discussion
----------

silence wrong exception

This fixes #163 by silencing the mistakenly thrown exception.

Commits
-------

e70acbd silence wrong exception
@xabbuh xabbuh deleted the issue-163 branch June 10, 2015 08:15
@xabbuh
Copy link
Member Author

xabbuh commented Jun 10, 2015

we should open an issue or a PR on the SE to remind fabpot to update the SE to the latest edition of the distribution bundle to fix this.

Doesn't this happen automatically when the archive is built?

@weaverryan
Copy link
Member

@xabbuh I actually don't know if a full composer update is part of updating the SE, or if fabpot just updates the composer.lock to a new symfony/symfony version. Anyways, he did update it before the 2.7.1 release today:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer requires Intl
3 participants