This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Added support for a specific directory in demo command #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
demo-with-directory
branch
from
c80ef4e to
5ad7096
Compare
| @@ -38,22 +38,29 @@ protected function initialize(InputInterface $input, OutputInterface $output) | |||
| { | |||
| parent::initialize($input, $output); | |||
|
|
|||
| $this->projectDir = getcwd(); | |||
| if ('symfony_demo' === $input->getArgument('directory')) { | |||
There was a problem hiding this comment.
I would do this only if the argument has not been given at all, but not depending on the vaue if given.
lyrixx
force-pushed
the
demo-with-directory
branch
from
5ad7096 to
7a8569f
Compare
lyrixx
force-pushed
the
demo-with-directory
branch
from
7a8569f to
8a9c43b
Compare
|
Thanks @lyrixx. |
javiereguiluz
added a commit
that referenced
this pull request
May 6, 2015
…lyrixx) This PR was merged into the 1.0-dev branch. Discussion ---------- Added support for a specific directory in demo command fixes #154 Commits ------- 8a9c43b Added support for a specific directory in demo command
| @@ -150,6 +152,19 @@ protected function download() | |||
| return $this; | |||
| } | |||
|
|
|||
| protected function checkProjectName() | |||
There was a problem hiding this comment.
you should remove the method from NewCommand too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #154