Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

fix handling of missing patch version #120

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 26, 2015

When the user tried to install the Symfony Standard Edition with just
specifying the minor version (like symfony new blog 2.3), the
installer failed for two reasons:

  • The use statement for the Client class was missing when it was
    used to download the list of available versions from symfony.com.
  • The URL from where the archive should be downloaded was build before
    the patch version was evaluated. Therefore, the archive of the actual
    Symfony version to be installed could not be found (it was tried to
    download an archive for 2.3 while the archive actually had to be
    referenced for 2.3.26).

This fixes #119.

When the user tried to install the Symfony Standard Edition with just
specifying the minor version (like `symfony new blog 2.3`), the
installer failed for two reasons:

* The `use` statement for the `Client` class was missing when it was
  used to download the list of available versions from symfony.com.
* The URL from where the archive should be downloaded was build before
  the patch version was evaluated. Therefore, the archive of the actual
  Symfony version to be installed could not be found (it was tried to
  download an archive for `2.3` while the archive actually had to be
  referenced for `2.3.26`).

This fixes #119.
@xabbuh
Copy link
Member Author

xabbuh commented Mar 26, 2015

ping @javiereguiluz

This should probably be merged asap and published on symfony.com so that people will be able to fully use the command again.

@javiereguiluz
Copy link
Member

@xabbuh thanks a lot! I like it as an emergency solution. But when we have time, I prefer to define an abstract method called getRemoteFileUrl().

@javiereguiluz javiereguiluz merged commit 52ad07c into symfony:master Mar 26, 2015
javiereguiluz added a commit that referenced this pull request Mar 26, 2015
This PR was merged into the 1.0-dev branch.

Discussion
----------

fix handling of missing patch version

When the user tried to install the Symfony Standard Edition with just
specifying the minor version (like `symfony new blog 2.3`), the
installer failed for two reasons:

* The `use` statement for the `Client` class was missing when it was
  used to download the list of available versions from symfony.com.
* The URL from where the archive should be downloaded was build before
  the patch version was evaluated. Therefore, the archive of the actual
  Symfony version to be installed could not be found (it was tried to
  download an archive for `2.3` while the archive actually had to be
  referenced for `2.3.26`).

This fixes #119.

Commits
-------

52ad07c fix handling of missing patch version
@javiereguiluz
Copy link
Member

A new Symfony Installer version has been published. I've tested it successfully, but please test it and report any problem. Thanks!

@xabbuh xabbuh deleted the issue-119 branch March 26, 2015 15:54
@xabbuh
Copy link
Member Author

xabbuh commented Mar 26, 2015

@javiereguiluz I agree with you. I didn't have the time to review #118 carefully enough, but I plan to have a look at it tonight, apply @stof's feedback and do the change you suggested here too.

Anyway, if you happen to find time to do it yourself, feel free do it. :)

javiereguiluz added a commit that referenced this pull request Mar 29, 2015
This PR was squashed before being merged into the 1.0-dev branch (closes #121).

Discussion
----------

Improved the Download abstract command

This PR addresses the comments made by @stof in #118 and tries to improve the emergency solution provided by @xabbuh in #120.

Commits
-------

7cf9611 Improved the Download abstract command
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create a new symfony 2.3 project
2 participants