Replacing EntityManagerInterface -> $this->getDoctrine()->getManager(); #8089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a conversation that we should use the helpers when they are available
weaverryan
commented
Jun 26, 2017
| @@ -586,7 +588,7 @@ Take a look at the previous example in more detail: | |||
|
|
|||
| .. _doctrine-entity-manager: | |||
|
|
|||
| * **line 10** The ``EntityManagerInterface`` type-hint tells Symfony to pass you Doctrine's | |||
| * **line 13** The ``$this->getDoctrine()->getManager()`` method gets Doctrine's | |||
There was a problem hiding this comment.
I verified all the lines are correct via platform.sh
GuilhemN
reviewed
Jun 26, 2017
doctrine/associations.rst
Outdated
| { | ||
| $product = $em->getRepository('AppBundle:Product') | ||
| $product = $this->getDoctrine() | ||
| ->getManager() |
There was a problem hiding this comment.
this line is useless, right?
There was a problem hiding this comment.
good catch - removed it :)
GuilhemN
reviewed
Jun 29, 2017
doctrine.rst
Outdated
| @@ -551,10 +551,11 @@ a controller, this is pretty easy. Add the following method to the | |||
| use Doctrine\ORM\EntityManagerInterface; | |||
| use Doctrine\Common\Persistence\ManagerRegistry; | |||
form/form_dependencies.rst
Outdated
| { | ||
| // or fetch the em via the container | ||
| // $em = $this->get('doctrine')->getManager(); | ||
| $em = $this->get('doctrine')->getManager(); |
There was a problem hiding this comment.
We're not using getDoctrine() here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was updating everything to use type-hints for 3.3, we had discussed that we should probably recommend using the helper method
$this->getDoctrine()in the controller instead of type-hintingEntityManagerInterface. This reverts my changes to reflect that.