Update the generateSql tool and regenerate schemas #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Apr 25, 2021
wouterj
approved these changes
Apr 25, 2021
|
Thank you @mbabker! |
stof
reviewed
Apr 28, 2021
| $loader->addPrefixes([ | ||
| 'Symfony' => __DIR__.'/../../../../../..', | ||
| 'Doctrine\\Common' => __DIR__.'/../../../../../../../vendor/doctrine-common/lib', | ||
| 'Doctrine\\DBAL\\Migrations' => __DIR__.'/../../../../../../../vendor/doctrine-migrations/lib', |
There was a problem hiding this comment.
this was not even about the time it was permanently split. It was from the time where we migrated to composer rather than a deps file (these paths are not where composer puts files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generateSqltool looks like it hasn't been updated in any meaningful way since this component was permanently split off from the monorepo and definitely couldn't work in its current state. The tool is updated and the schema updated with DBAL 3.1.