-
-
Notifications
You must be signed in to change notification settings - Fork 663
Add sonata-project/notification-bundle recipe #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
covex-nn
commented
Feb 24, 2018
Q | A |
---|---|
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
703c12a
to
475c4d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
As we can't determine if the user is using Entities, PHPCR or Documents we can't go this way and we will have to fall back to using easyextends. So you can remove the Entity, serialization and orm configuration. Can you make an RFC on https://github.com/sonata-project/dev-kit and we can further discuss this there? |
@kunicmarko20 i thought, that removing ORM annotations will solve that problem =) i should ask first about it, sorry |
475c4d4
to
5253d9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
@kunicmarko20 PR is ready, please review |
Good job, now we need packs |
@symfony-flex-server review please |
@Nyholm the README.rst says that after a |
@symfony-flex-server merge please |
cc @jordisala1991 @greg0ire @core23 @OskarStark can someone approve this? |
@Nyholm how do we get this merged? |
Maybe someone, not a member of @sonata-project, have to approve PR? |
@symfony-flex-server review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
@symfony-flex-server merge please or not, if you don't want to |
Every other PR that was merged had to be approved by Symfony Core, so I guess we can't just merge it like this. |
@kunicmarko20 @jordisala1991 i hoped, that a member of @sonata-project is a |
how do we become trusted users? |
Given this description, I should be a trusted user, why can't I merge this? |
@fabpot you asked to add comment here, this PR was not merged automaticaly |
Is there a reason why pull requests without errors like this will not be merged? |
@patrickbussmann I think a bug is the most probable reason, and it has yet to be determined, see #302 (comment) |
@jordisala1991 you need to approve the pull request, which you have not done yet. |
@fabpot he did and me either and we are both members of sonata-project: |
@symfony-flex-server review please =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
I will have a look :) |
Thank you very much! |
And fixed :) |
Hooray =) Thank you! |