Skip to content

feat: Make DockerComposeConfigurator compatible with "false" string #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Jul 8, 2025

This fixes #1060

With this MR DockerComposeConfigurator will recognize "false" string a proper boolean.

I use filter_var function, I think this is a good solution because it requires only a single method call to fix the issue.

With filter_var function:

  • true, 1, "true", "yes", "1", and "on" are recognized as true as well.
  • any other value is false.

Additionally this function is already used in the same method some lines below:

$answer = self::askDockerSupport($io, $recipe);
} elseif (filter_var($_SERVER['SYMFONY_DOCKER'], \FILTER_VALIDATE_BOOLEAN)) {
$answer = 'p';

@fabpot
Copy link
Member

fabpot commented Jul 9, 2025

Thank you @jawira.

@fabpot fabpot merged commit b70dc5d into symfony:2.x Jul 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DockerComposeConfigurator do not honors composer.json configuration
5 participants