feat: Make DockerComposeConfigurator compatible with "false" string #1061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1060
With this MR
DockerComposeConfigurator
will recognize"false"
string a proper boolean.I use
filter_var
function, I think this is a good solution because it requires only a single method call to fix the issue.With
filter_var
function:true
as well.false
.Additionally this function is already used in the same method some lines below:
flex/src/Configurator/DockerComposeConfigurator.php
Lines 115 to 117 in 423c36e