Skip to content

Fix Fedora/RedHat installation location (#474) #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix Fedora/RedHat installation location (#474) #510

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f92446
Fix Fedora/RedHat installation location
aostrowski-hbn Mar 31, 2025
6da52eb
Fix CMake 4.0.0 build break
aostrowski-hbn Apr 1, 2025
03918d1
install py files from cmake
isuruf Apr 1, 2025
fe65477
fix cmake_minimum_required
isuruf Apr 1, 2025
973e4c3
fix rhel again
aostrowski-hbn Apr 1, 2025
85fd800
Fix build_ext on MSVC
aostrowski-hbn Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 2.8.12...4.0.0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait for symengine/symengine#2096 before this starts working. Will it be available right after it's merged or should we also wait for a release of the library?

Should we go with CMAKE_POLICY_VERSION_MINIMUM until symengine/symengine gets the fix?

if (POLICY CMP0057)
cmake_policy(SET CMP0057 NEW) # needed for llvm >= 16
Expand Down
2 changes: 1 addition & 1 deletion cmake/FindPython.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ if (${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
endif()

execute_process(
COMMAND ${PYTHON_BIN} -c "from sysconfig import get_paths; print(get_paths()['purelib'])"
COMMAND ${PYTHON_BIN} -c "from sysconfig import get_paths; print(get_paths()['platlib'])"
OUTPUT_VARIABLE PYTHON_INSTALL_PATH_tmp
)
string(STRIP ${PYTHON_INSTALL_PATH_tmp} PYTHON_INSTALL_PATH_tmp)
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def cmake_build(self):

cmake_cmd = ["cmake", source_dir,
"-DCMAKE_BUILD_TYPE=" + cmake_build_type[0],
"-DSYMENGINE_INSTALL_PY_FILES=OFF",
"-DSYMENGINE_INSTALL_PY_FILES=ON",
]
cmake_cmd.extend(process_opts(cmake_opts))
if not path.exists(path.join(build_dir, "CMakeCache.txt")):
Expand Down Expand Up @@ -232,7 +232,7 @@ def finalize_options(self):
url="https://github.com/symengine/symengine.py",
python_requires='>=3.9,<4',
zip_safe=False,
packages=['symengine', 'symengine.lib', 'symengine.tests'],
packages=[],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change causes the following error in CI:

ModuleNotFoundError: No module named 'symengine.test_utilities'

I reverted it in the latest commit.

cmdclass = cmdclass,
classifiers=[
'License :: OSI Approved :: MIT License',
Expand Down
Loading