[pull] swiftwasm-release/5.3 from release/5.3 #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This enables using the 5.3 compiler with a Swift.interface from a master compiler.
Instead, just ignore them.
The Clang importer has an old hack that makes OS_object and its subclasses implicitly "objc_runtime_visible" (which maps to the "runtime" foreign class kind in Swift). Now that the headers in the SDK all use the appropriate annotation, remove the hack. Fixes rdar://problem/64778416. (cherry picked from commit 1867e0d)
[5.3] parse COW support builtins as no-ops
A malformed mangled name that ends in a truncated symbolic reference could trigger a read beyond the end of the name. This is because the code that grabs the next four bytes bypasses the existing bounds checks. Insert an explicit bounds check to guard against this.
…ument To preserve subtype relationship between element types of a collection passed as an argument to a parameter represented by another collection type let's extend opening of the collection types to be done for arguments to @autoclosure parameters as well because implicit closure is transparent to the caller. Resolves: [SR-13135](https://bugs.swift.org/browse/SR-13135) Resolves: rdar://problem/65088975 (cherry picked from commit 739ba4b)
[5.3][CSBindings] Open collection binding associated with @autoclosure argument
…ack-5.3 [Clang importer] Remove the OS_object objc_runtime_visible hack.
…allExpr (cherry picked from commit 7c5b6d7)
…lang#32725) * SR-12486: `T.self is Any.Protocol` is broken This turned out to be fallout from swiftlang#27572 which was in turn motivated by our confusing metatype syntax when generic variables are bound to protocols. In particular, the earlier PR was an attempt to make the expression `x is T.Type` (where `T` is a generic type variable bound to a protocol `P`) behave the same as `x is P.Type` (where `P` is a protocol). Unfortunately, the generic `T.Type` actually binds to `P.Protocol` in this case (not `P.Type`), so the original motivation was flawed, and as it happens, `x is T.Type` already behaved the same as `x is P.Protocol` in this situation. This PR reverts that earlier change and beefs up some of the tests around these behaviors. Resolves SR-12486 Resolves rdar://62201613 Reverts PR#27572
[5.3][Sema] Mark the direct callee as being a callee for all ApplyExpr not just CallExpr
MaxDesiatov
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )