Skip to content

Add toolchain version picker #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2025

Conversation

roulpriya
Copy link
Contributor

@roulpriya roulpriya commented Jul 1, 2025

Description

Add a toolchain version picker in the status bar

Issue: Fixes Issue #1671

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

@roulpriya roulpriya marked this pull request as ready for review July 2, 2025 06:00
@matthewbastien
Copy link
Member

@roulpriya it looks like CI failed on the formatting check. You'll want to install the Prettier extension (should be part of this repo's recommended extensions) and enable format on save in VS Code. You can also run formatting manually on the command line with:

npx prettier --write .

Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I missed that the number was set to TBD.

@roulpriya
Copy link
Contributor Author

Whoops, I missed that the number was set to TBD.

Oh, no worries, I will raise another PR.

CHANGELOG.md Outdated
@@ -15,6 +16,7 @@
- Ensure document symbols are provided for folders in multi-root workspaces ([#1668](https://github.com/swiftlang/vscode-swift/pull/1668))

## 2.6.1 - 2025-06-27
- Add clickable toolchain selection to Swift version status bar item ([#TBD](https://github.com/swiftlang/vscode-swift/pull/1674))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, fixed it.

CHANGELOG.md Outdated
@@ -4,6 +4,8 @@

### Added

- Add clickable toolchain selection to Swift version status bar item ([#1674](https://github.com/swiftlang/vscode-swift/pull/1674))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line but otherwise looks good thanks

@matthewbastien matthewbastien merged commit bc2c546 into swiftlang:main Jul 4, 2025
18 checks passed
@plemarquand
Copy link
Contributor

Verified with 323d996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants