Ensure document symbols are provided for folders in multi root workspaces #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
test-modification-tests
branch
4 times, most recently
from
7c08d62 to
c025d41
Compare
plemarquand
changed the title
plemarquand
force-pushed
the
test-modification-tests
branch
2 times, most recently
from
d498a45 to
5a2a80b
Compare
plemarquand
changed the title
plemarquand
force-pushed
the
test-modification-tests
branch
2 times, most recently
from
57a2ec2 to
a315ca3
Compare
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
rbenegal
reviewed
Jun 30, 2025
`addFolder` in the LSP client was checking to see if the folder being added was a root folder. If the user is working in a multi root workspace document symbols would not be provided if they were for any folder except the first one added. This also prevented the test explorer from properly initializing. Check to see if the folder being added is in the list of VS Code workspace folders and associate the folder with the onDocumentSymbols request from the LSP. Issue: swiftlang#1669
plemarquand
force-pushed
the
test-modification-tests
branch
from
a315ca3 to
f95c1e9
Compare
rbenegal
approved these changes
Jun 30, 2025
|
Is there a reason the code-workspace test run missed this, i.e. need for new/modified tests? |
|
There were no tests covering modification (textDocument/tests LSP req), only finding tests on workspace open (workspace/tests). I've added some new tests in this patch. |
award999
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is working in a multi root workspace document symbols would not be provided if they were for any folder except the first one added. This also prevented the test explorer from properly initializing.
Check to see if the folder being added is in the list of VS Code workspace folders and associate the folder with the onDocumentSymbols request from the LSP.
Issue: #1669