Adds mapValues and compactMapValues to CxxDictionary:
#83429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyFanFan
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
hnrklssn
as code owners
egorzhdan
reviewed
Jul 30, 2025
| @@ -144,6 +144,58 @@ extension CxxDictionary { | |||
| } | |||
| } | |||
|
|
|||
| public func mapValues<R, E>( | |||
There was a problem hiding this comment.
Should this method also be @inlinable?
There was a problem hiding this comment.
Thanks for the suggestion! I've added the @inlinable attribute.
Could you please re-trigger the test job?
| } | ||
|
|
||
| @inlinable | ||
| @_disfavoredOverload |
There was a problem hiding this comment.
Just trying to understand this better, why do we need @_disfavoredOverload on this overload?
There was a problem hiding this comment.
Without @_disfavoredOverload, this method would call itself recursively by default.
|
@swift-ci please smoke test |
CrazyFanFan
force-pushed
the
feature/cxx_map_mapvalues_and_compactmapvalues
branch
from
cecfa9f to
4426912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.