[stdlib] Update UTF8Span documentation
#83418
Merged
+204
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartini51
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Looks good, with minor fixes. I marked stuff only once, and I'll let you copy/paste or find/replace.
One other phrasing to revise is "every time it is called". This needs to use contractions "it's called" but is also passive voice — who is doing the calling? If possible, rewrite to make the subject clear, like "every time you call this method".
Co-authored-by: Alex Martini <[email protected]>
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend formatting of
Substring.utf8Spanexample code.Use DocC tables in
Unicode.UTF8.ValidationErroroverview.