-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[wasm] Build and install Foundation for Wasm SDK #82285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[wasm] Build and install Foundation for Wasm SDK #82285
Conversation
@swift-ci smoke test |
self._build_libxml2(swift_host_triple, has_pthread, wasi_sysroot) | ||
self._build_foundation(swift_host_triple, has_pthread, wasi_sysroot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Foundation built for any other platform for smoke test
CI trigger? If not, I think we should make _build_libxml2
and _build_foundation
conditional on --foundation
passed to build-script
or included in a preset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke test builds Foundation for the host platform as well.
@swift-ci smoke test macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the trade-off is worth it for now. We can address build time regressions later by making the build-script invocations concurrent in the future.
c99d60e
to
81b908e
Compare
@swift-ci smoke test Linux platform |
No description provided.