[build-script] build LLVMTestingSupport only if target is generated #82278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the build will fail if we pass `--no-llvm-include-tests` or we set directly `LLVM_INCLUDE_TESTS` directly to `FALSE`/`OFF` Addresses rdar://153562845
This was apparently missing in the migration of the llvm product from build-script-impl to build-script,
edymtt
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
|
@swift-ci please test |
|
@swift-ci please build toolchain |
etcwilde
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the build will fail if we pass
--no-llvm-include-testsor weset directly
LLVM_INCLUDE_TESTSdirectly toFALSE/OFFAlso take the chance to wire
--llvm-include-testsproperly in build-scriptAddresses rdar://153562845