-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[wasm] Enable building swift-testing for wasm32-unknown-wasip1-threads #81793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kateinoigakukun
merged 1 commit into
swiftlang:main
from
kateinoigakukun:yt/build-swift-testing-wasip1-threads
Jun 12, 2025
Merged
[wasm] Enable building swift-testing for wasm32-unknown-wasip1-threads #81793
kateinoigakukun
merged 1 commit into
swiftlang:main
from
kateinoigakukun:yt/build-swift-testing-wasip1-threads
Jun 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aedbdc7
to
eec9cdc
Compare
@swift-ci smoke test |
1 similar comment
@swift-ci smoke test |
eec9cdc
to
9fd10c4
Compare
kateinoigakukun
commented
Jun 11, 2025
# for stdlib build, we can fully unify library builds with the | ||
# regular path. | ||
dest_dir = self._target_package_path(swift_host_triple) | ||
def _append_platform_cmake_options(self, cmake_options, swift_host_triple, has_pthread, wasi_sysroot): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split out platform options configuration so that we can reuse it for the upcoming Foundation and libxml2 build
9fd10c4
to
b702fbf
Compare
@swift-ci smoke test |
b702fbf
to
e68f87f
Compare
@swift-ci smoke test |
@swift-ci smote test |
e68f87f
to
df9bed6
Compare
@swift-ci smote test |
@swift-ci smoke test |
@swift-ci build toolchain |
MaxDesiatov
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no blocker to enable the build anymore.