Skip to content

Concurrency: handle android similar to Linux #80201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

compnerd
Copy link
Member

Android should use the dispatch based, Linux platform executor. However, Android reports as os(Android) rather than os(Linux). This adjusts the condition to ensure that we have a platform executor factory for Android.

Android should use the dispatch based, Linux platform executor. However,
Android reports as `os(Android)` rather than `os(Linux)`. This adjusts
the condition to ensure that we have a platform executor factory for
Android.
@compnerd compnerd requested a review from ktoso as a code owner March 21, 2025 18:00
@compnerd compnerd requested review from al45tair and removed request for ktoso March 21, 2025 18:00
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd
Copy link
Member Author

CC: @drexin - seems that this is a build break that was introduced for Android - can we get this in to unblock CI systems?

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@drexin drexin merged commit 586c113 into swiftlang:main Mar 21, 2025
0 of 3 checks passed
@compnerd compnerd deleted the concurrent-androids branch March 21, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants