TypeCheckType: Do not fail after emitting a warning #79934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov and
xedin
as code owners
Also remove the redundant diagnosis altogether. This case is already handled by the existential syntax checker just fine.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
Mar 18, 2025
…ifier` Tests that verify diagnostics for valid code are best kept separate from those that verify errors. swiftlang#79934 is a great example of why this is important. This change adds an option to disallow error expectations that can be used to prevent folks from inadvertently introducing error verifications to tests that are supposed to compile successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the redundant diagnosis altogether. This case is already handled by the existential syntax checker just fine.
Resolves #79916