🍒[cxx-interop] Workaround compiler error when importing AppKit/UIKit with C++ interop #78741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith C++ interop The AppKit/UIKit overlay refers to symbols declared via NS_OPTIONS macro, which is causing issues in C++ language mode due to the macro definition being different. This teaches the module interface loader to drop the C++ interop flag when rebuilding the AppKit and UIKit overlay from its interface. This is the same fix as swiftlang#78636, but for different modules. rdar://143033209 (cherry picked from commit 7323a75)
porglezomp
requested review from
hborla,
slavapestov,
xedin,
eeckstein,
shahmishal,
mikeash,
al45tair,
compnerd,
ahoppen,
bnbarham,
hamishknight,
rintaro,
a team,
ktoso,
xymus,
artemcm,
kavon,
jckarter,
rjmccall,
CodaFi,
DougGregor,
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
tshortli,
adrian-prantl,
AnthonyLatsis and
cachemeifyoucan
as code owners
porglezomp
requested review from
beccadax,
ian-twilightcoder,
etcwilde,
edymtt and
justice-adams-apple
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this on the wrong branch initially blew up the reviewer list. Re-opened as: #78742