[6.0] Revert "[region-isolation] Make "unknown pattern error" always an error #75364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or." This reverts commit b63781f. We found some cases where due to malformed IR that we allow through due to either us compiling for strict-concurrency=complete+swift-5 or swift-6 + preconcurrency, that we can actually have actor isolation mismatch. I am going to in a subsequent commit add a better phrasing here. But for now, just undo the conversion from error -> warning. rdar://131757602
|
@swift-ci test |
ktoso
approved these changes
Jul 19, 2024
hborla
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This reverts commit b63781f.
We found some cases where due to malformed IR that we allow through due to either us compiling for strict-concurrency=complete+swift-5 or swift-6 + preconcurrency, that we can actually have actor isolation mismatch. I am going to in a subsequent commit add a better phrasing here. But for now, just undo the conversion from error -> warning.
Radars:
Original PRs:
Risk: Low. This is just reverting a diagnostic from being an error in swift 5 + strict-concurrency to being a warning.
Testing: This is a pure revert whose correctness can be seen just by reading the code, so there isn't really a test. Additionally, we do not emit this error in any of our current tests (since we fix them), so there isn't something I can check to see if it is a warning or error.
Reviewer: @ktoso