[6.0][region-isolation] Change capturing a value into an async let that is not further sent into an actor isolated function to use a new style error. #74879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n also work with TransferNonSendable versions of the error. This asserts only option is an option to make it quicker/easier to triage unknown pattern match errors by aborting when we emit it (allowing one to immediately drop into the debugger at that point). Previously, it only happened for errors in RegionAnalysis not in TransferNonSendable itself. (cherry picked from commit 78d74cf)
… not further sent into an actor isolated function to use a new style error. Just going through and fixing sending errors. rdar://130915737 (cherry picked from commit 02e003f)
…oved cleanup transfernonsendable_asynclet.swift. NFC. (cherry picked from commit 31df5f2)
|
@swift-ci test |
|
@swift-ci test |
(cherry picked from commit e9e5c4e)
|
@swift-ci test |
ktoso
approved these changes
Jul 2, 2024
DougGregor
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This PR cleans up the async let diagnostic so that we emit a new style "named" error instead of a type based error.
Radars:
Original PRs:
Risk: Low. Just modifies a diagnostic to improve readability and quality of implementation.
Testing: Added tests to the compiler.
Reviewer: @ktoso