Skip to content

[stdlib] Don't use aarch64 hint for arm targets in Synchronization #74258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jun 10, 2024

On ARM targets, the intrinsic is called llvm.arm.hint instead of llvm.aarch64.hint. Make sure we call that for those targets.

Resolves: #74186

@Azoy Azoy requested a review from hyp June 10, 2024 16:24
@Azoy Azoy requested a review from a team as a code owner June 10, 2024 16:24
@Azoy
Copy link
Contributor Author

Azoy commented Jun 10, 2024

@swift-ci please smoke test

@Azoy Azoy merged commit 09d025b into swiftlang:main Jun 10, 2024
3 checks passed
@Azoy Azoy deleted the synchronization-arm-hints branch June 10, 2024 20:58
@finagolfin
Copy link
Member

Thanks, I'll try this out.

Azoy added a commit to Azoy/swift that referenced this pull request Jun 16, 2024
[stdlib] Don't use aarch64 hint for arm targets in Synchronization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift crashes when building Synchronization stdlib Swift module for ARMv7 Android
2 participants