[Regex] Really build _RegexParser without resilience #70953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My real motivation for fixing this out of the blue is to resolve the dozens of warnings like this that we see every time we build the compiler and standard libraries: |
tshortli
force-pushed
the
fragile-regex-parser-module
branch
from
67e766c to
f3c3cb5
Compare
|
@swift-ci please test |
Azoy
approved these changes
Jan 17, 2024
This was originally attempted with swiftlang#58810 but `_RegexParser` still ended up being built with library evolution enabled because the `-enable-library-evolution` flag is added to the command line after calling `add_swift_target_library` and therefore stripping the flag out of `SWIFT_COMPILE_FLAGS` does nothing. The `IS_FRAGILE` flag was introduced to support building C++ interop overlay modules without library evolution and it can now be used to prevent `_RegexParser` from being built with library evolution. Resolves rdar://93067204
tshortli
force-pushed
the
fragile-regex-parser-module
branch
from
f3c3cb5 to
8d1b578
Compare
|
@swift-ci please test |
tshortli
added a commit
to tshortli/swift-installer-scripts
that referenced
this pull request
Jan 17, 2024
The module is becoming non-resilient in swiftlang/swift#70953.
|
swiftlang/swift-installer-scripts#274 @swift-ci please smoke test |
|
swiftlang/swift-installer-scripts#274 @swift-ci please build toolchain macOS platform |
|
swiftlang/swift-installer-scripts#274 @swift-ci please build toolchain Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally attempted with #58810 but
_RegexParserstill ended up being built with library evolution enabled because the-enable-library-evolutionflag is added to the command line after callingadd_swift_target_libraryand therefore stripping the flag out ofSWIFT_COMPILE_FLAGSdoes nothing.The
IS_FRAGILEflag was introduced to support building C++ interop overlay modules without library evolution and it can now be used to prevent_RegexParserfrom being built with library evolution.Resolves rdar://93067204