Skip to content

SwiftCompilerSources: force the -static flag #68125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

compnerd
Copy link
Member

These libraries are built statically for static linking. SPM currently does not support libraries, and this will ensure that we properly build the library target for consumption into the compiler.

These libraries are built statically for static linking.  SPM currently
does not support libraries, and this will ensure that we properly build
the library target for consumption into the compiler.
@compnerd compnerd requested a review from eeckstein as a code owner August 24, 2023 18:17
@compnerd
Copy link
Member Author

@swift-ci please smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@compnerd
Copy link
Member Author

@swift-ci please clean test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd compnerd merged commit 9268736 into swiftlang:main Aug 26, 2023
@compnerd compnerd deleted the libraries branch August 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants