[Observation] Refactor for state machine (and behavior robustness) and adjust protocol requirement names #64414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes and alter the behavior of value emissions to be based upon transactionality
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
phausler
force-pushed
the
pr/observation_rework
branch
from
aa03389 to
68b14c5
Compare
|
@swift-ci please test |
phausler
force-pushed
the
pr/observation_rework
branch
from
68b14c5 to
13a1377
Compare
|
@swift-ci please test |
phausler
force-pushed
the
pr/observation_rework
branch
from
13a1377 to
2ef8aec
Compare
|
@swift-ci please test |
phausler
force-pushed
the
pr/observation_rework
branch
from
2ef8aec to
ba4d850
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the implementation for the registrar to now have a robust state machine to transition from discrete states for deterministic results (particularly for testing). The primitive requirements for the
Observableprotocol are now namedchangesandvaluesto reflect their more common parlance usage/meaning (and also more accurately reflect other APIs). Thevaluesprotocol requirement now emits values such that if a property changes in-between suspension it can now determine that the value has changed and emit that (whereas previously the value may have been dropped).The module name was also corrected to have a leading underscore since that module has not yet been accepted as a proposal - after acceptance it will be renamed back to dropping the leading underscore (demarcating that it is part of the official builds and is no longer experimental).