Skip to content

[cxx-interop] Recognize CxxStdlib as an alias for std #61099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

egorzhdan
Copy link
Contributor

C++ standard library module is called std. To make it more clear to a Swift developer that this module is a C++ stdlib, and not a Swift stdlib, let's rename it to CxxStdlib.

This is the first step in the module rename. We don't ban std in this patch to be able to build SwiftCompilerSources with hosttools until a new Swift compiler is shipped.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 14, 2022
@egorzhdan egorzhdan requested review from hyp and zoecarver September 14, 2022 15:54
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@hyp
Copy link
Contributor

hyp commented Sep 14, 2022

Can you add a test where you import CxxStdlib from source?

C++ standard library module is called `std`. To make it more clear to a Swift developer that this module is a C++ stdlib, and not a Swift stdlib, let's rename it to `CxxStdlib`.

This is the first step in the module rename. We don't ban `std` in this patch to be able to build SwiftCompilerSources with hosttools until a new Swift compiler is shipped.
@egorzhdan egorzhdan force-pushed the egorzhdan/cxxstdlib-step1 branch from 398b51d to e3c5838 Compare September 15, 2022 13:38
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

Can you add a test where you import CxxStdlib from source?

@hyp yeap, added a test.

@egorzhdan egorzhdan merged commit 2dd820b into main Sep 15, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxxstdlib-step1 branch September 15, 2022 16:53
egorzhdan added a commit that referenced this pull request Nov 29, 2022
…lib`

This is the second step in renaming the C++ stdlib module `std` into `CxxStdlib`.

See #61099.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants