Skip to content

[debug-info] Expand test coverage for move function debug info. #42152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2022
Merged

[debug-info] Expand test coverage for move function debug info. #42152

merged 2 commits into from
Apr 2, 2022

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Apr 2, 2022

Specifically:

  1. Early on in this work I disabled alloc-stack-hoisting on these tests since there was a bug within the pass that caused the debug info to be zapped. I only fixed it for dbg.addr and not for dbg.declare to avoid perturbing codegen. As a result though, when I remove the flag, we lose some dbg.declare (specifically the variable "m") in some of the tests. This resulted in my needing to fix up the DWARF file check code to remove that variable when it did not exist. This does not change what we were really testing... the behavior of llvm.dbg.addr.
  2. I loosened the dwarf pattern matching on the debug info tests so they work on both arm64 and x86_64 macOS.

gottesmm added 2 commits April 1, 2022 22:21
@gottesmm
[debug-info] Edit the move debug info tests so we can test it both on…
f9c1534 
… macOS x86 and arm64.
@gottesmm
[debug-info] Re-enable alloc-stack-hoisting on the move function tests.
5f73a17 
I fixed the issues exposed with alloc-stack-hoisting for llvm.dbg.addr some time
ago but didn't update this test.

The test changes are b/c I did not fix this for llvm.dbg.declare resulting in us
losing the variable "m" in certain situations. "k" the thing we care about is
actually fine though.
@gottesmm
Copy link
Contributor Author

gottesmm commented Apr 2, 2022

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Apr 2, 2022

Just adding more tests...

@gottesmm gottesmm merged commit 6b13190 into swiftlang:main Apr 2, 2022
@gottesmm gottesmm deleted the pr-a06afd22f46794c4401f318b39e6dba531eb7bc2 branch April 2, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gottesmm