[gardening] Update SILLowerAggregateInstrs to be of a more modern style. #32810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a really simple pass that isn't going to be touched for a long time after I am done fixing the pass for ownership. So it makes sense to clean it up now. I am doing this as a separate commit before updating for ownership.
|
Nothing too crazy here. |
|
@swift-ci smoke test |
atrick
reviewed
Jul 10, 2020
| // Simplify aggregate instructions into scalar instructions. | ||
| // | ||
| /// | ||
| /// \file |
There was a problem hiding this comment.
I really don't like the \file tag. Isn't that automatically recognized just like doc comments on declarations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really simple pass that isn't going to be touched for a long time
after I am done fixing the pass for ownership. So it makes sense to clean it up
now. I am doing this as a separate commit before updating for ownership.