Skip to content

[build-script] Tie llvm, swift, and lldb to the same sysroot #32802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

[build-script] Tie llvm, swift, and lldb to the same sysroot #32802

merged 1 commit into from
Jul 10, 2020

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Jul 10, 2020

This resolves build failures in lldb when building with Apple-internal SDKs.

rdar://62895058

@vedantk
Copy link
Contributor Author

vedantk commented Jul 10, 2020

@swift-ci smoke test

shahmishal
shahmishal approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

JDevlieghere
JDevlieghere approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vedantk
Copy link
Contributor Author

vedantk commented Jul 10, 2020

error: -[FunctionalTests.MiscellaneousTestCase testSwiftTestParallel] : XCTAssertTrue failed

swiftpm testing failed, but swift & lldb built.

@vedantk
Copy link
Contributor Author

vedantk commented Jul 10, 2020

@swift-ci smoke test OS X platform

@JDevlieghere
Copy link
Contributor

I took the liberty to merge it so it can propagate down the automergers overnight.

@JDevlieghere JDevlieghere merged commit d1a54a5 into swiftlang:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere JDevlieghere approved these changes

@shahmishal shahmishal shahmishal approved these changes

@edymtt edymtt Awaiting requested review from edymtt

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedantk @JDevlieghere @shahmishal