[lit] Detect lldb by checking both for lldb_build_root and that that root contains an lldb exec. #32643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…root contains an lldb exec. Otherwise, if one builds lldb with a specific build-script config and does not fully build lldb, one will not be blocked from testing. With this change, one instead gets a warning that we found a configured lldb dir, but not lldb exec.
|
People were talking about hitting this when they were messing around with infer (which creates build dir). Seems like a good overall change than erroring. |
|
@swift-ci test |
JDevlieghere
reviewed
Jul 1, 2020
| @@ -100,6 +100,8 @@ def get_simulator_command(run_os, run_cpu, sdk_path): | |||
|
|
|||
| def get_lldb_python_path(lldb_build_root): | |||
| lldb_path = os.path.join(lldb_build_root, 'bin', 'lldb') | |||
| if not os.access(lldb_path, os.F_OK): | |||
There was a problem hiding this comment.
Is there a reason this is preferable compared to something like os.path.exists?
There was a problem hiding this comment.
No. I just did it this way out of habit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if one builds lldb with a specific build-script config and does not
fully build lldb, one will not be blocked from testing. With this change, one
instead gets a warning that we found a configured lldb dir, but not lldb exec.