Skip to content

[Clang importer] Remove the OS_object objc_runtime_visible hack #32620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

DougGregor
Copy link
Member

The Clang importer has an old hack that makes OS_object and its subclasses
implicitly "objc_runtime_visible" (which maps to the "runtime" foreign
class kind in Swift). Now that the headers in the SDK all use the
appropriate annotation, remove the hack.

Fixes rdar://problem/64778416.

The Clang importer has an old hack that makes OS_object and its subclasses
implicitly "objc_runtime_visible" (which maps to the "runtime" foreign
class kind in Swift). Now that the headers in the SDK all use the
appropriate annotation, remove the hack.

Fixes rdar://problem/64778416.
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci test source compatibility

@DougGregor
Copy link
Member Author

All of the source-compatibility failures are due to a SwiftPM issue, and those packages are unlikely to uncover any additional issues. This should be fine.

@DougGregor DougGregor merged commit ed1dc0f into swiftlang:master Jul 2, 2020
@DougGregor DougGregor deleted the remove-os-object-hack branch July 2, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant