[test][stdlib] Add strto*_l stubs for OpenBSD. #32395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template defined for Cygwin and friends does not handle failure cases properly so the NumericParsing unit test fails. To get the correct test behavior, we need to use an implementation such as like in the Windows specializations or the non-Cygwin implementation that takes a function pointer. However, adding additional specializations would be too wordy, and OpenBSD doesn't have locale-dependent definitions of the relevant strto* functions. We could add a specialization for a two-argument function pointer, but that becomes too repetitive. Instead, implement a few stubs and use the preprocessor, a la the implementation for Android.
|
Hmm, do you think its worth trying to unify the Android and OpenBSD paths? |
|
I think there's a lot of scope for cleanup here, especially as well as how that Happy to take a stab at it, but it might make more sense to do it in another PR. |
|
Okay, a follow up for that would definitely be a good thing. |
|
@swift-ci please test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template defined for Cygwin and friends does not handle failure cases
properly so the NumericParsing unit test fails. To get the correct test
behavior, we need to use an implementation such as like in the Windows
specializations or the non-Cygwin implementation that takes a function
pointer.
However, adding additional specializations would be too wordy, and
OpenBSD doesn't have locale-dependent definitions of the relevant strto*
functions. We could add a specialization for a two-argument function
pointer, but that becomes too repetitive.
Instead, implement a few stubs and use the preprocessor, a la the
implementation for Android.