[cmake] Move ar linking optimization rule into UnixCompileRules.cmake and only run it on Unix-like platforms. #32111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and only run it on Unix-like platforms. This doesn't make sense on Windows and from what compnerd has said it doesnt even appear in the ninja rules file. This also moves this rule out of the main flow of the top level CMakeLists.txt file so I can reuse it when compiling the stdlib using a sub-cmake invocation.
|
@swift-ci clean test |
compnerd
approved these changes
May 31, 2020
|
Build failed |
|
The linux error is I think the weird module issue. Going to try again with a smoke test. |
|
@swift-ci smoke test linux platform |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't make sense on Windows and from what compnerd has said it doesnt
even appear in the ninja rules file. This also moves this rule out of the main
flow of the top level CMakeLists.txt file so I can reuse it when compiling the
stdlib using a sub-cmake invocation.