runtime: extract swiftDemangling into a support library
#32092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
compnerd
force-pushed
the
undeocrating-undecoration
branch
from
d866b66 to
5643a72
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
`swiftDemangling` was built three times: 1. swiftc 2. swiftRuntime 3. swiftReflection Fold the last two instances into a single build, sharing the objects across both the target libraries. This ensures that `swiftDemangling` is built with the same compiler as the target libraries and that the target library build remains self-contained.
compnerd
force-pushed
the
undeocrating-undecoration
branch
from
5643a72 to
fb58228
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
mikeash
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftDemanglingwas built three times:Fold the last two instances into a single build, sharing the objects
across both the target libraries. This ensures that
swiftDemanglingis built with the same compiler as the target libraries and that the
target library build remains self-contained.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.