Add dependencies where targets depend on inclusions from unspecified targets. #30732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…targets. A follow-up PR adds a flag to control an inline namespace that allows symbols in libDemangling to be distinguished between the runtime and the compiler. These dependencies ensure that the flag is plumbed through for inclusions of Demangling headers that aren't already covered by existing `target_link_libraries`.
compnerd
reviewed
Mar 31, 2020
|
@swift-ci please test |
|
CC: @drexin |
compnerd
approved these changes
Apr 1, 2020
|
This shouldn't really impact anything outside of the dependencies generated, and the symbolic resolution previously indicates that we would have included the libraries anyways. This is more about the build time dependency tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up PR (#30733) adds a flag to control an inline namespace that allows
symbols in libDemangling to be distinguished between the runtime and
the compiler. These dependencies ensure that the flag is plumbed
through for inclusions of Demangling headers that aren't already
covered by existing
target_link_libraries.cc: @compnerd