Skip to content

Revert "Clang function types v2: Electric Boogaloo (parsing + printing)" #29033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahmishal merged 1 commit into from
Jan 7, 2020
Merged

Revert "Clang function types v2: Electric Boogaloo (parsing + printing)" #29033

shahmishal merged 1 commit into from
Jan 7, 2020

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jan 7, 2020

Reverts #28737

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2020

This broke the macOS, Linux, Windows builder, revert until it can be re-tested.

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2020

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2020

CC: @varungandhi-apple

@compnerd compnerd mentioned this pull request Jan 7, 2020
Merged
@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Jan 7, 2020

Oh shit, I forgot there was an intersecting part which was not tested together. Yes, let us revert this.

@shahmishal shahmishal merged commit 596961c into master Jan 7, 2020
@compnerd compnerd deleted the revert-28737-vg-v3-clang-types-in-swiftinterface branch January 7, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@varungandhi-apple varungandhi-apple varungandhi-apple approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@compnerd @varungandhi-apple @shahmishal