Skip to content

[TBDGen] disable tests for linux #27307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2019
Merged

[TBDGen] disable tests for linux #27307

merged 1 commit into from
Sep 25, 2019

Conversation

cyndyishida
Copy link
Contributor

@cyndyishida cyndyishida commented Sep 23, 2019 •
edited
Loading

It doesn't make sense for tbd files to be generated on linux machine since linux linkers wouldn't consume them anyway. This should be reflected in the tests and repair the failing tests from #27073

Resolves rdar://problem/55635561

@cyndyishida
Copy link
Contributor Author

@swift-ci Please test

@harlanhaskins
Copy link
Contributor

I think we'd rather use REQUIRES: OS=macosx || OS=ios || OS=tvos || OS=watchos, so we disable them rather than XFAILing them. I don't know if there is a better way to spell "Apple platform"...

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 63c1be47fc7ba6ffd14af06d27627da93f829b9d

@cyndyishida
Copy link
Contributor Author

cyndyishida commented Sep 23, 2019 •
edited
Loading

I think we'd rather use REQUIRES: OS=macosx || OS=ios || OS=tvos || OS=watchos, so we disable them rather than XFAILing them. I don't know if there is a better way to spell "Apple platform"...

I think either that or adding logic in lit.cfg for OSType=Darwin or VenderType=apple, would that be alright to add? all extractable from the target_triple that passes the OS value

@cyndyishida cyndyishida force-pushed the TBD/disable-linux-tests branch from 63c1be4 to 53b5bfe Compare September 23, 2019 22:56
@cyndyishida
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 63c1be47fc7ba6ffd14af06d27627da93f829b9d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 63c1be47fc7ba6ffd14af06d27627da93f829b9d

@cachemeifyoucan
Copy link
Contributor

I will run swiftc -frontend -target $DARWIN_TARGET directly instead of marking them as required on Darwin platform only. Running swift compiler on linux with darwin platform should still generate TBD file correctly.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 63c1be47fc7ba6ffd14af06d27627da93f829b9d

@shahmishal
Copy link
Member

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 53b5bfe4e71767d1316841e5d51cd2f3d7bb5cc1

@cyndyishida cyndyishida force-pushed the TBD/disable-linux-tests branch from 53b5bfe to 5bed832 Compare September 24, 2019 17:05
compnerd
compnerd reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the export, just hard code the darwin target in all the places. This wont work properly on Windows.

@cyndyishida cyndyishida force-pushed the TBD/disable-linux-tests branch 2 times, most recently from 289be3e to cd72ef0 Compare September 25, 2019 15:31
@shahmishal
Copy link
Member

@swift-ci Please test

1 similar comment
@shahmishal
Copy link
Member

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 53b5bfe4e71767d1316841e5d51cd2f3d7bb5cc1

cachemeifyoucan
cachemeifyoucan approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - cd72ef07f7e66e2f980266833599ec0280c3938c

@shahmishal
Copy link
Member 

12:33:30     Swift(linux-x86_64) :: reproducible-builds/swiftc-emit-tbd.swift
12:33:30     Swift(linux-x86_64) :: TBD/global.swift
12:33:30     Swift(linux-x86_64) :: TBD/installapi-flag.swift
12:33:30     Swift(linux-x86_64) :: TBD/enum.swift
12:33:30     Swift(linux-x86_64) :: TBD/function.swift
12:33:30     Swift(linux-x86_64) :: TBD/opaque_result_type.swift
12:33:30     Swift(linux-x86_64) :: TBD/struct.swift
12:33:30     Swift(linux-x86_64) :: TBD/main.swift
12:33:30     Swift(linux-x86_64) :: TBD/specialization.swift
12:33:30     Swift(linux-x86_64) :: TBD/protocol.swift
12:33:30     Swift(linux-x86_64) :: TBD/output-path-deduction.swift
12:33:30     Swift(linux-x86_64) :: TBD/dylib-version.swift
12:33:30     Swift(linux-x86_64) :: TBD/class.swift
12:33:30     Swift(linux-x86_64) :: TBD/app-extension.swift
12:33:30     Swift(linux-x86_64) :: TBD/abi-version.swift

@cyndyishida It's still failing on Linux

@cyndyishida cyndyishida force-pushed the TBD/disable-linux-tests branch from cd72ef0 to 5a3f07a Compare September 25, 2019 20:10
@cyndyishida cyndyishida force-pushed the TBD/disable-linux-tests branch from 5a3f07a to e6b3fd4 Compare September 25, 2019 20:11
@cyndyishida
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - cd72ef07f7e66e2f980266833599ec0280c3938c

beccadax
beccadax reviewed Sep 25, 2019
View reviewed changes
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e6b3fd4

@cyndyishida
Copy link
Contributor Author

Build failed
Swift Test Linux Platform
Git Sha - e6b3fd4

Only failing linux job now @shahmishal
14:28:11 Swift(linux-x86_64) :: Runtime/linux-fatal-backtrace.swift

@cyndyishida cyndyishida merged commit 2585d6c into swiftlang:master-rebranch Sep 25, 2019
@cyndyishida cyndyishida deleted the TBD/disable-linux-tests branch September 25, 2019 22:48
CodaFi added a commit to CodaFi/swift that referenced this pull request Jul 1, 2020
@CodaFi
[Gardening] Use Vendor=apple Where Possible
50159d1 
This simplifies the usual bundle of OS checks

OS=macosx || OS=ios || OS=tvos || OS=watchos

into

VENDOR=apple

which was added in swiftlang#27307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

@beccadax beccadax beccadax left review comments

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

@harlanhaskins harlanhaskins Awaiting requested review from harlanhaskins

@ributzka ributzka Awaiting requested review from ributzka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cyndyishida @harlanhaskins @swift-ci @cachemeifyoucan @shahmishal @compnerd @beccadax