Ensure monitorProcessTermination is ALWAYS called after body runs #90
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
force-pushed
the
eng/PR-always-monitor
branch
from
b66271c to
59caa66
Compare
jakepetroules
commented
Jun 25, 2025
| @@ -779,15 +788,15 @@ internal func withAsyncTaskCleanupHandler<Result>( | |||
| // so _immediately_ if the failure scenario is due to parent task | |||
| // cancellation. We do so in a detached Task to prevent cancellation | |||
| // of the parent task from interrupting enumeration of the stream itself. | |||
| await Task.detached { | |||
| await withUncancelledTask { | |||
There was a problem hiding this comment.
Already had an abstraction for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #88. We need to ensure monitorProcessTermination is ALWAYS called after body runs, regardless of whether it threw an error or not.
Closes #89