Move to async implementations of UserToolchain.init and SwiftSDK.hostSwiftSDK
#9251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
async-usertoolchain-swiftsdk
branch
from
387cb78 to
9ee10c2
Compare
rauhul
approved these changes
Oct 15, 2025
plemarquand
force-pushed
the
async-usertoolchain-swiftsdk
branch
6 times, most recently
from
ff43faa to
01419ce
Compare
Contributor
Author
|
@swift-ci test windows |
plemarquand
force-pushed
the
async-usertoolchain-swiftsdk
branch
from
ac0ac36 to
c93aa44
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci test windows |
plemarquand
force-pushed
the
async-usertoolchain-swiftsdk
branch
from
c93aa44 to
a60b1a6
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci test windows |
Both methods previously made calls to the version of `AsyncProcess.checkNonZeroExit` that blocks the calling thread, forcing consumers to either block or implement workarounds to hop off the calling thread. This patch adds async versions of these methods and ports most usages to use them, marking the required call sites as async and awaiting them.
plemarquand
force-pushed
the
async-usertoolchain-swiftsdk
branch
from
a60b1a6 to
d13c06e
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both methods previously made calls to the version of
AsyncProcess.popenthat blocks the calling thread, forcing consumers to either block or implement workarounds to hop off the calling thread, if they were calling from MainActor.This patch switches to the async version of AsyncProcess.popen and converts callers to use them, marking the required call sites as async and awaiting them.