Use deployment target instead of 9999 for min OS version #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
commented
Jan 17, 2024
| "FoundationPreview 0.3:macOS 9999, iOS 9999, tvOS 9999, watchOS 9999", | ||
| "FoundationPreview 0.4:macOS 9999, iOS 9999, tvOS 9999, watchOS 9999", | ||
| "FoundationPreview 0.1:macOS 13.3, iOS 16.4, tvOS 16.4, watchOS 9.4", | ||
| "FoundationPredicate 0.1:macOS 14, iOS 17, tvOS 17, watchOS 10", |
There was a problem hiding this comment.
Predicate has an actual OS dependency of macOS 14 (et. al.) and higher. We use a different macro for it.
jmschonfeld
approved these changes
Jan 18, 2024
parkera
added a commit
to parkera/swift-foundation
that referenced
this pull request
Jan 18, 2024
parkera
added a commit
that referenced
this pull request
Jan 18, 2024
* Calendar Sequence API * Add Calendar_Gregorian support and placeholders for dayOfYear * Address review feedback and fix test failure * Disable day of year for in-progress Gregorian calendar implementation * Adjust the Calendar_Gregorian use of dayOfYear pending some more work there * Remove if available FoundationPreview 0.4 checks (see #384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the placeholder
9999availability, use the min deployment target. This simplifies implementation inside the package -- we no longer need to check for availability of something which is entirely contained within the package itself due to an availability marker on public API.