Skip to content

[6.2][CMake] Use new 16 KB page alignment on 64-bit Android (#71) #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

finagolfin
Copy link
Member

@finagolfin finagolfin commented Aug 11, 2025

Explanation: Add a linker flag for the upcoming 16 KB page support in Android.

Scope: Only affects Android

Issue: None

Original PR: #71

Risk: None, only affects Android

Testing: Passed trunk CI and confirmed locally that this fixed the alignment

Reviewer: @compnerd

@swift-ci test

@finagolfin finagolfin requested a review from compnerd August 11, 2025 17:56
@finagolfin
Copy link
Member Author

@iCharlesHu, I believe you have review permissions here, can we get this tiny Android-only pull in?

@finagolfin
Copy link
Member Author

@parkera, could you have someone take a look?

@parkera parkera requested review from iCharlesHu and itingliu August 18, 2025 15:59
@parkera
Copy link
Contributor

parkera commented Aug 18, 2025

Seems fine to me - cc @iCharlesHu and @itingliu too

@parkera parkera merged commit ddd11fa into swiftlang:release/6.2 Aug 18, 2025
21 checks passed
@finagolfin finagolfin deleted the droid branch August 18, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants