Lower severity of source-symbol-not-found diagnostic

[d-ronnqvist]

Bug/issue #, if applicable:

Summary

This PR makes two changes to the diagnostic when the source symbol of a symbol graph relationship can't be found:

• Elaborate in the summary and explanation to clarify that this is an issue with the tool that created the symbol graph and not something that the developer can resolve themselves.
• Lower the severity of this diagnostic so that this issue doesn't fail the build.

Since the solution to this issue is for the tool that created the symbol graph file to not include this relationship (or move it to a different file), it's safe for DocC to proceed without processing this symbol graph relationship.

Dependencies

None.

Testing

• Manually edit a symbol graph file to add a relationship where the "source" isn't a symbol ID for a symbol defined in that symbol graph file.
• Build documentation for that symbol graph file.
• There should be a warning, not an error, about the incorrect symbol graph relationship.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

• Added Updated tests
• Ran the ./bin/test script and it succeeded
• Updated documentation if necessary Not applicable

[d-ronnqvist]

@swift-ci please test

[franklinsch]

One thing we might want to consider here is direct the user to file a bug report on Swift/Clang with information that can help diagnose the issue (in our case, the symbol graph file or at least a portion of it).

[d-ronnqvist]

Yes, I was thinking of that but at the point where we're creating these diagnostics we no longer know which symbol graph file a given relationship came from.

We could include information about how to report an issue for both Swift and Clang and let the developer decide which to file a bug report on.

[d-ronnqvist]

After an offline discussion about this PR I've further reduced the severity to a debug-only assertion in 2e64b4b.

[d-ronnqvist]

@swift-ci please test

[QuietMisdreavus]

Looks great! I'm glad we're taking out this error; it's confusing and unactionable, and creates a situation where an issue in other tools causes Swift-DocC to fail, when it could just as easily continue on.

[d-ronnqvist]

@swift-ci please test