[6.0] Avoid visiting symbol markup twice when there's a documentation extension file (#951) #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion file (swiftlang#951) * Get the source URL from the visited markup instead of resolving links twice. rdar://129677496 --------- Co-authored-by: Pat Shaughnessy <[email protected]> * Remove 'source' arguments that are inferred from 'range.source' * Add unrelated comment about incorrect diagnostic suggestion * Code review: test ReferenceResolver diagnostic ranges * Code review: extract docChunk computation into property * Code review: extract check that symbol inherits docs from other module --------- Co-authored-by: Pat Shaughnessy <[email protected]>
|
@swift-ci please test |
franklinsch
approved these changes
Jun 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a source of crashes before [6.0] Handle various out-of-bounds diagnostic ranges in default diagnostics formatter (#947) #948