[6.0] Much faster navigator index creation for mixed Swift and Objective-C projects #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…projects (swiftlang#917) * Fix a navigator index performance for mixed Swift/Objective-C projects rdar://127759734 * Use new apply-patch function in other places * Deprecate unused `RenderNode/childrenRelationship(for:)` * Move inner function in test to avoid warning about captured state * Fix unrelated issue where the language in disambiguated references wasn't stable * Move new indexable-render-node-representation protocol top-level * Remove extra word in code comment Co-authored-by: Maya Epps <[email protected]> --------- Co-authored-by: Maya Epps <[email protected]>
|
@swift-ci please test |
franklinsch
approved these changes
May 23, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves the build time for large (10k+ symbols) mixed Swift and Objective-C projects; about 5 times faster total
docc converttime. It does so by fixing a major bottleneck in the creation of the navigator index.Note:
Some new code depended on the ability to sort source languages which was an underlying change in #856 but which was never cherry-picked over to the 6.0 release. I brought over only that change in 6444036.