Support either language representation's relative links in documentation extension files #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files rdar://120380627
d-ronnqvist
force-pushed
the
allow-counterpart-links-in-extension-files
branch
from
60455fa to
557be05
Compare
|
@swift-ci please test |
d-ronnqvist
added a commit
to d-ronnqvist/swift-docc
that referenced
this pull request
Mar 28, 2024
…files (swiftlang#858) rdar://120380627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://120380627
Summary
This builds on #854 to allow documentation extension files to use either language representation's relative links when the extension file is associated with a symbol with language refinements.
Dependencies
None
Testing
In a multi-source-language project;
Add a documentation extension file for a container symbol (for example a class or a struct) that have representations in both languages.
Add some relative links to members of this type using either language's spelling of those symbols. Those links should resolve.
When viewing the rendered page, the resolved links should display the language specific spelling of those members, regardless of which spelling was used in the link.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded