[5.10] Replace spaces with dashes in links to articles #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace spaces and punctuation with dashes in links to articles rdar://119577248 * Add test that file name punctuation warn about reference collisions * Update what punctuation is used in file names in new test * Use simpler punctuation in file name in test for older Swift versions * Only replace whitespaces with dashes (not punctuation) * Move linkName function to only file where it has a reason to be used
|
@swift-ci please test |
franklinsch
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #773
Explanation: Fix a bug where articles with whitespace in their filename couldn't be linked to by using "-" instead of sequences of whitespace characters in the written links.
Scope: Articles with whitespace in their filenames.
Issue: rdar://119577248
Risk: Low.
Testing: Added tests and ran the existing automated tests.
Reviewer: @sofiaromorales
Note that I made one additional commit 93b099d to update the added test to account for a feature that isn't cherry-picked into the 'release/5.10' branch but that exist on 'main' where #773 was originally merged.