Skip to content

[5.9] Fix a crash when linking to a symbol that doesn't have a page #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

[5.9] Fix a crash when linking to a symbol that doesn't have a page #618

merged 1 commit into from
Jun 13, 2023

Conversation

d-ronnqvist
Copy link
Contributor

  • Explanation: Warn instead of crashing when linking to a symbol that doesn't have a page in that documentation build.
  • Scope: Crashes for certain authored symbol links.
  • Issue: rdar://110177531
  • Risk: Low.
  • Testing: Added unit test to verify that a minimal example that used to crash now raise a warning instead.
  • Original PR: Fix a crash when linking to a symbol that doesn't have a page #617
  • Reviewers: @QuietMisdreavus

@d-ronnqvist d-ronnqvist requested a review from franklinsch June 8, 2023 23:46
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 08df11b into swiftlang:release/5.9 Jun 13, 2023
@d-ronnqvist d-ronnqvist deleted the link-to-symbol-without-page-5.9 branch June 13, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-ronnqvist @franklinsch