[5.9] Disfavor default implementations and synthesized symbols in link collisions #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-ronnqvist
commented
Apr 11, 2023
d-ronnqvist
commented
- Explanation: Avoid need for some link disambiguation by deprioritizing synthesized symbols and default implementations in link collisions.
- Scope: Symbol link disambiguation.
- Issue: rdar://98781530
- Risk: Low. Existing links with disambiguation continue to work the same as before. New links can avoid disambiguation.
- Testing: Updated test assertions verify that link collisions with deprioritized symbols can omit disambiguation.
- Original PR: Disfavor default implementations and synthesized symbols in link collisions #540
- Reviewers: @QuietMisdreavus
…isions (swiftlang#540) * Disfavor default implementations and synthesized symbols in link collisions rdar://98781530 * Add link to SymbolKit enhancement request about synthesized symbols
|
@swift-ci please test |
|
@swift-ci please test |
franklinsch
approved these changes
Apr 12, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.