Skip to content

[5.9] Fix a crash when a protocol with a default implementation is aliased with the same name #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

[5.9] Fix a crash when a protocol with a default implementation is aliased with the same name #536

merged 1 commit into from
Apr 11, 2023

Conversation

d-ronnqvist
Copy link
Contributor

Cherry-pick of #534

  • Explanation: Fix a crash when a protocol with a default implementation in one module is both @_export imported and type aliased in another module.
  • Scope: Crash in specific target setup.
  • Radar: rdar://107075861
  • Risk: Low.
  • Testing: New tests verify that the setup doesn't crash and that exported symbol in the Outer target documentation has the same hierarchy as the original symbol in the Inner target documentation.
  • Reviewer: @franklinsch

@d-ronnqvist
Fix a crash when a protocol with a default implementation is aliased …
2fdbd22 
…with the same name (swiftlang#534)

* Fix crash when exported import protocol is aliased with same name

rdar://107623749

* Remove incorrect memberOf relationships in handcrafted test symbol data
@d-ronnqvist d-ronnqvist requested a review from franklinsch April 6, 2023 16:28
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 626a05f into swiftlang:release/5.9 Apr 11, 2023
@d-ronnqvist d-ronnqvist deleted the default-impl-exported-import-crash-5.9 branch April 11, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-ronnqvist @franklinsch